[TS-2789] Typo in HttpSessionManger would cause ATS reuse wrong session to origin server.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: HTTP
• Labels: yahoo
• Assignee: Bryan Call
• Reporter: kang li
• Created: 08/May/14 11:54
• Updated: 18/Dec/14 05:03
• Resolved: 08/May/14 20:02

Description

There is a typo in HttpSessionManger

(ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) == ats_ip_port_cast(addr)))

The fix would be

    -          (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) == ats_ip_port_cast(addr)))
    +          (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(&s->server_ip.sa) == ats_ip_port_cast(addr)))

This typo skip the port check, so if requests to same origin server would use one same session even though different port.

Which would cause ATS-5.0 reuse wrong session to origin.