Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-249

INK_SDK_VERSION_5_2 -> TS_SDK_VERSION_2_0

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      We should clean up the SDK version "registry", since we "promise" to keep this API compatible within the 2.0.x releases. My suggestion is to simply replace INKSDKVersion with this:

      typedef enum

      { TS_SDK_VERSION_2_0 = 0, INK_SDK_VERSION_5_2 = 0, }

      TSSDKVersion;

      (we'd insert TS_SDK_VERSION_2_2, TS_SDK_VERSION_3_0 etc. as we make new "major" releases).

        Activity

        Hide
        zwoop Leif Hedstrom added a comment -

        To avoid too much confusion, and as suggested by Bryan, I did not change the "names" to use the new TS prefix, but kept the INK prefix. But the new (and only) version name is

        INK_SDK_VERSION_2_0

        Show
        zwoop Leif Hedstrom added a comment - To avoid too much confusion, and as suggested by Bryan, I did not change the "names" to use the new TS prefix, but kept the INK prefix. But the new (and only) version name is INK_SDK_VERSION_2_0
        Hide
        zwoop Leif Hedstrom added a comment -

        Proposed diff, I'd like to have this reviewed before committing to trunk, because I'd also like this to be a candidate for backporting to 2.0.x branch.

        Show
        zwoop Leif Hedstrom added a comment - Proposed diff, I'd like to have this reviewed before committing to trunk, because I'd also like this to be a candidate for backporting to 2.0.x branch.

          People

          • Assignee:
            zwoop Leif Hedstrom
            Reporter:
            zwoop Leif Hedstrom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development