[TS-2396] UrlRewrite.cc free the node of queue not correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2.0
• Component/s: HTTP
• Assignee: Yu Qing
• Reporter: Yu Qing
• Created: 26/Nov/13 02:07
• Updated: 18/Dec/14 05:07
• Resolved: 26/Nov/13 22:30

Description

the codes as:

960 void
961 UrlRewrite::_destroyList(RegexMappingList &mappings)
962 {
963   forl_LL(RegexMapping, list_iter, mappings) {
964     delete list_iter->url_map;
965     if (list_iter->re) {
966       pcre_free(list_iter->re);
967     }
968     if (list_iter->re_extra) {
969       pcre_free(list_iter->re_extra);
970     }
971     if (list_iter->to_url_host_template) {
972       ats_free(list_iter->to_url_host_template);
973     }
974     delete list_iter;
975   }
976   mappings.clear();
977 }

Can't delete list_iter in the loop because the list_iter is the iterator for the loop.

Issue Links

• relates to: TS-3038 Deletion of iterator in middle of iteration