Traffic Server
  1. Traffic Server
  2. TS-2361

load regex_remap relative to config directory

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.0
    • Component/s: Plugins
    • Labels:
      None

      Description

      The location of the regex_remap configuration is not well-defined if it is a relative path. Either it will be found in the current directory (which is undefined), or a hard-coded global directory will be used.

      This change always uses the absolute path if an absolute path is provided. If a relative path is provided, then we load that relative to the configured Traffic Server configuration directory.

      1. TS-2361.diff
        8 kB
        James Peach

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 4626716fd390efdab12bae35a25abf41cf88c937 in branch refs/heads/master from James Peach
        [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4626716 ]

        TS-2361: improve regex_remap plugin loading semantics

        The location of the regex_remap configuration is not well-defined
        if it is a relative path. Either it will be found in the current
        directory (which is undefined), or a hard-coded global directory
        will be used.

        This change always uses the absolute path if an absolute path is
        provided. If a relative path is provided, then we load that relative
        to the configured Traffic Server configuration directory.

        Show
        ASF subversion and git services added a comment - Commit 4626716fd390efdab12bae35a25abf41cf88c937 in branch refs/heads/master from James Peach [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4626716 ] TS-2361 : improve regex_remap plugin loading semantics The location of the regex_remap configuration is not well-defined if it is a relative path. Either it will be found in the current directory (which is undefined), or a hard-coded global directory will be used. This change always uses the absolute path if an absolute path is provided. If a relative path is provided, then we load that relative to the configured Traffic Server configuration directory.
        Hide
        James Peach added a comment -

        regex_remap currently looks in /usr/local/etc/regex_remap for it's config files. After this change it will look in the Traffic Server configuration directory (usually $PREFIX/etc/trafficserver). I don't think that this is going to break anyone in practice, but it is a compatibility break.

        Show
        James Peach added a comment - regex_remap currently looks in /usr/local/etc/regex_remap for it's config files. After this change it will look in the Traffic Server configuration directory (usually $PREFIX/etc/trafficserver). I don't think that this is going to break anyone in practice, but it is a compatibility break.

          People

          • Assignee:
            James Peach
            Reporter:
            James Peach
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development