Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-22

Collect common defines into global configuration header

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.0a
    • 2.1.0
    • Build
    • None
    • All

    Description

      The command lines to pass -D to g++ are quite long (passing in PACKAGE_VERSION, PACKAGE_NAME, etc). They ought to be collected into a common 'config.h' file generated by autoheader:
      http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers

      The #include <config.h> needs to be placed before any other header files, to prevent inconsistencies in declarations (for example, if it redefines const). Plus, not all files may need the include.

      This change will likely touch a lot of *.c, *.cc, *.h, and *.i files.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              andrewhsu Andrew Hsu
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: