[TS-1678] Unnecessary lock releasing in RecRegisterStat()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.1
• Component/s: Metrics
• Assignee: James Peach
• Reporter: Yunkai Zhang
• Created: 31/Jan/13 09:42
• Updated: 05/Jun/13 22:42
• Resolved: 16/Feb/13 19:06

Description

It seems that lock releasing in the following code is unnecessary and dangerous in some situation.

//-------------------------------------------------------------------------
// RecRegisterStat
//-------------------------------------------------------------------------
RecRecord *
RecRegisterStat(RecT rec_type, const char *name, RecDataT data_type, RecData data_default, RecPersistT persist_type)
{
  RecRecord *r = NULL;

  ink_rwlock_wrlock(&g_records_rwlock);
  if ((r = register_record(rec_type, name, data_type, data_default, false)) != NULL) {
    r->stat_meta.persist_type = persist_type;
    rec_mutex_release(&(r->lock));  //dangerous!!
  } else {
    ink_debug_assert(!"Can't register record!");
  }
  ink_rwlock_unlock(&g_records_rwlock);

  return r;
}