Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-1674

TSStatIntDecrement is broken

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.1
    • Component/s: TS API
    • Labels:
      None

      Description

      ATS keeps a thread-local copy of the stat value and aggregates it periodically and on demand when stats are being collected. However the decrement function doesn't let a value go negative. So in a thread that has not incremented this stat previously, the decrement call "fails". This negative value check is logically flawed as it doesn't account for the per-thread distribution of the stats.

        Attachments

        1. remove_per_thread_stats.patch
          53 kB
          Uri Shachar

          Issue Links

            Activity

              People

              • Assignee:
                briang Brian Geffon
                Reporter:
                briang Brian Geffon
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: