Traffic Server
  1. Traffic Server
  2. TS-1452

gzip build failure with Apple/clang-421.0.57

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.1
    • Component/s: Plugins
    • Labels:

      Description

      The gzip module has a couple of compiler errors failure with Apple/clang-421.0.57.

        Activity

        James Peach created issue -
        Hide
        James Peach added a comment -

        d8c5ac91dfea43a99fbb3d90e8eecf9b250200b2 TS-1452: gzip build failure with Apple/clang-421.0.57

        Otto, please review!

        Show
        James Peach added a comment - d8c5ac91dfea43a99fbb3d90e8eecf9b250200b2 TS-1452 : gzip build failure with Apple/clang-421.0.57 Otto, please review!
        James Peach made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.3.1 [ 12321686 ]
        Resolution Fixed [ 1 ]
        James Peach made changes -
        Component/s Plugins [ 12313151 ]
        James Peach made changes -
        Labels gzip
        Hide
        Otto van der Schaaf added a comment -

        These changes look fine to me. I will recheck that ssize_t/PRId64 are used where applicable in this plugin later this day, as I think there are other places those would be preferred.
        Thanks!

        Show
        Otto van der Schaaf added a comment - These changes look fine to me. I will recheck that ssize_t/PRId64 are used where applicable in this plugin later this day, as I think there are other places those would be preferred. Thanks!
        Hide
        Conan Wang added a comment -

        fail with gcc 4.1.2.

        /usr/local/bin/tsxs -c configuration.cc misc.cc gzip.cc -o gzip.so
          compiling configuration.cc -> configuration.lo
          compiling misc.cc -> misc.lo
        misc.cc: In function ‘void gzip_log_ratio(int64_t, int64_t)’:
        misc.cc:206: error: expected `)' before ‘PRId64’
        misc.cc:208: error: expected `)' before ‘PRId64’
        Compile failed: gcc -I/usr/local/trafficserver/include -g -pipe -Wall -Werror -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -fpic -c misc.cc -o misc.lo
        make: *** [gzip.so] Error 1
        
        Show
        Conan Wang added a comment - fail with gcc 4.1.2. /usr/local/bin/tsxs -c configuration.cc misc.cc gzip.cc -o gzip.so compiling configuration.cc -> configuration.lo compiling misc.cc -> misc.lo misc.cc: In function ‘void gzip_log_ratio(int64_t, int64_t)’: misc.cc:206: error: expected `)' before ‘PRId64’ misc.cc:208: error: expected `)' before ‘PRId64’ Compile failed: gcc -I/usr/local/trafficserver/include -g -pipe -Wall -Werror -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -fpic -c misc.cc -o misc.lo make: *** [gzip.so] Error 1
        Hide
        Otto van der Schaaf added a comment -

        could you retry compiling with the new automake file?

        Show
        Otto van der Schaaf added a comment - could you retry compiling with the new automake file?
        Hide
        James Peach added a comment -

        Probably needs __STDC_FORMAT_MACROS defined.

        Show
        James Peach added a comment - Probably needs __STDC_FORMAT_MACROS defined.
        Otto van der Schaaf made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Otto van der Schaaf added a comment -

        __STDC_FORMAT_MACROS added in 99c70136854201ae862f63847c7ffe4406905a97

        Show
        Otto van der Schaaf added a comment - __STDC_FORMAT_MACROS added in 99c70136854201ae862f63847c7ffe4406905a97
        Hide
        Conan Wang added a comment -

        __STDC_FORMAT_MACROS works.

        Show
        Conan Wang added a comment - __STDC_FORMAT_MACROS works.
        Hide
        James Peach added a comment -

        Resolved by Otto's commit above.

        Show
        James Peach added a comment - Resolved by Otto's commit above.
        James Peach made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Leif Hedstrom made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            James Peach
            Reporter:
            James Peach
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development