Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-14

InkAPI is not 64-bit clean

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0a
    • 2.1.4
    • TS API
    • None
    • x86_64 linux

    Description

      This is different than the 64-bit port in that it effects the public API. In particular there are functions which use 'int' where they should be using other types for things like sizes which could exceed 2^32, the 'int' size even on 64-bit linux. Specifically:

      api/include/InkAPI.h: inkapi int INKfread(INKFile filep, void *buf, int length);

      But a full review of the API should be conducted and the types updated. In this case inku64, ink_off_t or most likely size_t would
      be more appropriate. All of these are 64-bit on 64-bit linux.

      Attachments

        1. TS-14.diff
          62 kB
          Leif Hedstrom

        Issue Links

          Activity

            People

              zwoop Leif Hedstrom
              jplevyak John Plevyak
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: