Traffic Server
  1. Traffic Server
  2. TS-1262

allow the alternate selection api to force an alternate using a magick return value

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.4
    • Component/s: None
    • Labels:
      None
    1. force alt selection w flt_max.diff
      1 kB
      Otto van der Schaaf
    2. force alt selection.diff
      1 kB
      Otto van der Schaaf

      Activity

      Otto van der Schaaf created issue -
      Otto van der Schaaf made changes -
      Field Original Value New Value
      Attachment force alt selection.diff [ 12527594 ]
      Otto van der Schaaf made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Otto van der Schaaf added a comment -

      a use case is picking an alternate based on a cookie value. this patch has been field tested.
      returning 999.0 from the select alternate hook will force the current alternate

      Show
      Otto van der Schaaf added a comment - a use case is picking an alternate based on a cookie value. this patch has been field tested. returning 999.0 from the select alternate hook will force the current alternate
      Hide
      Leif Hedstrom added a comment -

      Interesting. Curious, why 999.0? Is that an arbitrarily large number? Is there some better value we can use, to assure no conflicts here with other use cases ? FLT_MAX?

      Show
      Leif Hedstrom added a comment - Interesting. Curious, why 999.0? Is that an arbitrarily large number? Is there some better value we can use, to assure no conflicts here with other use cases ? FLT_MAX?
      Leif Hedstrom made changes -
      Assignee Leif Hedstrom [ zwoop ]
      Fix Version/s 3.1.4 [ 12318543 ]
      Hide
      Otto van der Schaaf added a comment -

      that number was abritrary indeed, i agree that FLT_MAX would probably make more sense.

      Show
      Otto van der Schaaf added a comment - that number was abritrary indeed, i agree that FLT_MAX would probably make more sense.
      Hide
      Leif Hedstrom added a comment -

      Can you prepare and test an updated patch ? I'll commit it when you do.

      Show
      Leif Hedstrom added a comment - Can you prepare and test an updated patch ? I'll commit it when you do.
      Otto van der Schaaf made changes -
      Attachment force alt selection w flt_max.diff [ 12528415 ]
      Hide
      Otto van der Schaaf added a comment -

      done

      Show
      Otto van der Schaaf added a comment - done
      Hide
      Leif Hedstrom added a comment -

      Resolved in:

      commit 8793e8cbbb87a1dbc6cb3825175d44df32931cbc
      Author:     Otto van der Schaaf <oschaaf at gmail dot com>
      AuthorDate: Tue May 22 15:06:48 2012 -0600
      Commit:     Leif Hedstrom <zwoop@apache.org>
      CommitDate: Tue May 22 15:06:48 2012 -0600
      
      Show
      Leif Hedstrom added a comment - Resolved in: commit 8793e8cbbb87a1dbc6cb3825175d44df32931cbc Author: Otto van der Schaaf <oschaaf at gmail dot com> AuthorDate: Tue May 22 15:06:48 2012 -0600 Commit: Leif Hedstrom <zwoop@apache.org> CommitDate: Tue May 22 15:06:48 2012 -0600
      Leif Hedstrom made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Leif Hedstrom made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Patch Available Patch Available
      39s 1 Otto van der Schaaf 16/May/12 10:06
      Patch Available Patch Available Resolved Resolved
      6d 12h 43m 1 Leif Hedstrom 22/May/12 22:50
      Resolved Resolved Closed Closed
      14d 2h 11m 1 Leif Hedstrom 06/Jun/12 01:01

        People

        • Assignee:
          Leif Hedstrom
          Reporter:
          Otto van der Schaaf
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development