Traffic Server
  1. Traffic Server
  2. TS-1127

Wrong returned value of incoming port address

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.1.4
    • Component/s: HTTP
    • Labels:
      None

      Description

      The API TSHttpTxnClientIncomingPortGet has been changed in Wed Oct 5 19:14:07 2011 (TS-926) and it returns another value.
      in the old version it returned the incoming port of the TS(the port which the client connected to the TS).
      in the new version the returned value is the sending port of the user.
      The different is in the line:

      • return sm->t_state.client_info.port;
        + return ink_inet_get_port(&sm->t_state.client_info.addr);

      The assignment of those two members (port, addr) are in the HttpSM.cc file

      ink_inet_copy(&t_state.client_info.addr, netvc->get_remote_addr());
      t_state.client_info.port = netvc->get_local_port();

      The old code gave the right answer from the port member, and the new one gives us wrong answer from the remote address.

      I attached a patch to fix this returned value.

      1. fix.patch
        0.4 kB
        Yakov Kopel

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Leif Hedstrom
            Reporter:
            Yakov Kopel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1m
              1m
              Remaining:
              Remaining Estimate - 1m
              1m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development