Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-1102

Cleanup obsolete debugging code

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.0.2
    • 3.1.3
    • Core, Logging, Performance
    • None

    • Any

    Description

      The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1 for all compilation environments, and it includes variadic argument macro support with ##VA_ARGS that deletes the final comma if no arguments are provided.
      Removing the added layer should also improve performance when high volume debugging is turned on.

      Attachments

        1. ats.benchmark
          3 kB
          Uri Shachar
        2. diags_cleanup.patch
          11 kB
          Uri Shachar
        3. diags_perf_and_remove_debugon.patch
          24 kB
          Uri Shachar
        4. diags_remove_debugon.patch
          24 kB
          Uri Shachar
        5. remove_prefix_arg_v2.patch
          20 kB
          Uri Shachar
        6. remove_prefix_arg_v3.patch
          21 kB
          Uri Shachar
        7. remove_prefix_arg.patch
          20 kB
          Uri Shachar

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. TS-1079 Add an API function to turn debugging on for specific transactions/sessions

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. TS-1121 --disable-diags configuration option does not do anything

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              zwoop Leif Hedstrom
              ushachar Uri Shachar
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Remaining Estimate - 24h
                  24h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified