Traffic Server
  1. Traffic Server
  2. TS-1090

Configuration and plugin support for SO_MARK (on supporting platforms)

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.4
    • Component/s: HTTP, Network, TS API
    • Labels:
      None

      Description

      SO_MARK allows for all packets sent out via a given socket to be pre-marked (similar to the -j MARK target in iptables, or the fwmark semantic in ip rules). This feature allows configuration to dictate SO_MARKs for accepting sockets, cluster sockets and origin server sockets independently. Additionally, plugins and internal systems can set per-transaction SO_MARKS for outgoing packets.

      1. TS-1090-leif.diff
        1 kB
        Leif Hedstrom
      2. so_mark.patch
        16 kB
        B Wyatt

        Activity

        B Wyatt created issue -
        Hide
        B Wyatt added a comment - - edited

        This patch implements the SO_MARK feature for linux systems (that include SO_MARK in the sys/socket.h)

        EDIT: I should mention that if the autoconf script cant find the linux headers/values it needs it will disable support for this feature. So while it is cross-platform friendly, it is not cross-platform functional at this time.

        Show
        B Wyatt added a comment - - edited This patch implements the SO_MARK feature for linux systems (that include SO_MARK in the sys/socket.h) EDIT: I should mention that if the autoconf script cant find the linux headers/values it needs it will disable support for this feature. So while it is cross-platform friendly, it is not cross-platform functional at this time.
        B Wyatt made changes -
        Field Original Value New Value
        Attachment so_mark.patch [ 12511512 ]
        Leif Hedstrom made changes -
        Assignee B Wyatt [ wanderingbort ]
        Fix Version/s 3.1.3 [ 12317969 ]
        Hide
        Leif Hedstrom added a comment -

        Moved to 3.1.4, please move bugs back to 3.1.3, which you will work on in the next 2 weeks.

        Show
        Leif Hedstrom added a comment - Moved to 3.1.4, please move bugs back to 3.1.3, which you will work on in the next 2 weeks.
        Leif Hedstrom made changes -
        Fix Version/s 3.1.4 [ 12318543 ]
        Fix Version/s 3.1.3 [ 12317969 ]
        Leif Hedstrom made changes -
        Fix Version/s 3.1.5 [ 12320056 ]
        Fix Version/s 3.1.4 [ 12318543 ]
        Leif Hedstrom made changes -
        Fix Version/s 3.1.4 [ 12318543 ]
        Fix Version/s 3.1.5 [ 12320056 ]
        B Wyatt made changes -
        Fix Version/s 3.3.0 [ 12316495 ]
        Fix Version/s 3.1.4 [ 12318543 ]
        B Wyatt made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.1.4 [ 12318543 ]
        Fix Version/s 3.3.0 [ 12316495 ]
        Resolution Fixed [ 1 ]
        Hide
        Leif Hedstrom added a comment -

        Bart, I'm having build warnings (lots of them) with this commit, due to the new configure.ac. I rewrote it, using an existing pattern that we use elsewhere in our configure.ac. It works for me, but let me know what you think. I kept the indentation from our existing code in configure.ac, I know it looks ugly, but everything configure is ugly imo .

        Show
        Leif Hedstrom added a comment - Bart, I'm having build warnings (lots of them) with this commit, due to the new configure.ac. I rewrote it, using an existing pattern that we use elsewhere in our configure.ac. It works for me, but let me know what you think. I kept the indentation from our existing code in configure.ac, I know it looks ugly, but everything configure is ugly imo .
        Leif Hedstrom made changes -
        Attachment TS-1090-leif.diff [ 12525716 ]
        Leif Hedstrom made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Leif Hedstrom added a comment -

        Fixed the configure warnings with:

        commit a30f9576643c8f97e7cdad1dac14ecccdb594f98
        Author: Leif Hedstrom <zwoop@apache.org>
        AuthorDate: Sun May 6 21:18:42 2012 -0600
        Commit: Leif Hedstrom <zwoop@apache.org>
        CommitDate: Sun May 6 21:18:42 2012 -0600

        Show
        Leif Hedstrom added a comment - Fixed the configure warnings with: commit a30f9576643c8f97e7cdad1dac14ecccdb594f98 Author: Leif Hedstrom <zwoop@apache.org> AuthorDate: Sun May 6 21:18:42 2012 -0600 Commit: Leif Hedstrom <zwoop@apache.org> CommitDate: Sun May 6 21:18:42 2012 -0600
        Leif Hedstrom made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Leif Hedstrom made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            B Wyatt
            Reporter:
            B Wyatt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development