[TS-1055] Wrong implementation of TSHttpSsnArgGet

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.1.2, 3.0.3
• Component/s: TS API
• Labels: api-change
• Assignee: Igor Galić
• Reporter: Yakov Kopel
• Created: 18/Dec/11 15:30
• Updated: 10/Jun/12 01:35
• Resolved: 19/Dec/11 04:11

Description

There is a different between the interface of TSHttpSsnArgGet and it implemenation.
In the interface (proxy/api/ts/ts.h.in):
tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
In the implementation(proxy/InkAPI.cc):
void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)

So, I wrote a simple patch to fix this problem:

Index: InkAPI.cc
===================================================================
— InkAPI.cc (revision 1220421)
+++ InkAPI.cc (working copy)
@@ -5500,7 +5500,7 @@
}

void *
-TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
+TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
{
sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);