MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-986

EXTERNAL DIALOG FAILING TO RESIZE TO CONTENT

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.6-core
    • Fix Version/s: 1.2.8-core
    • Component/s: Components
    • Labels:
      None
    • Environment:
      Win32 FireFox

      Description

      External "Trinidad" dialog windows are resized to content using the offsets
      of the internal frame. The script "_sizeWin" as part of the Trinidad commons
      script resource bundling is failing to calculate the actual size of the inner
      content frame.

      1. Window.patch
        0.9 kB
        Gary VanMatre

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        13s 1 Gary VanMatre 03/Mar/08 20:38
        Patch Available Patch Available Resolved Resolved
        20h 56m 1 Matt Cooper 04/Mar/08 17:34
        Resolved Resolved Reopened Reopened
        72d 58m 1 Matt Cooper 15/May/08 19:32
        Reopened Reopened Resolved Resolved
        3h 53m 1 Matt Cooper 15/May/08 23:26
        Resolved Resolved Closed Closed
        621d 10h 18m 1 Matthias Weßendorf 27/Jan/10 08:45
        Matthias Weßendorf made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Matt Cooper made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s  1.2.8-core [ 12313041 ]
        Fix Version/s 1.2.7-core [ 12312963 ]
        Fix Version/s 1.0.7-core [ 12312962 ]
        Resolution Fixed [ 1 ]
        Matt Cooper made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Matt Cooper added a comment -

        Reopening because an automatic height should not be used when the dialog has defined dimensions. Auto height should only be used when the dialog has undefined dimensions because otherwise the _sizeWin function will have dialog dimensions passed into it which means the dialog has a fixed height and thus contents of the body should be allowed to stretch (e.g. 100%) to match the height of the dialog.

        Right now, with an automatic height, a percent height inside of that would resolve to zero--at least on some browsers, if not most.

        Show
        Matt Cooper added a comment - Reopening because an automatic height should not be used when the dialog has defined dimensions. Auto height should only be used when the dialog has undefined dimensions because otherwise the _sizeWin function will have dialog dimensions passed into it which means the dialog has a fixed height and thus contents of the body should be allowed to stretch (e.g. 100%) to match the height of the dialog. Right now, with an automatic height, a percent height inside of that would resolve to zero--at least on some browsers, if not most.
        Matt Cooper made changes -
        Fix Version/s 1.2.7-core [ 12312963 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.2.6-core [ 12312923 ]
        Fix Version/s 1.0.7-core [ 12312962 ]
        Resolution Fixed [ 1 ]
        Matt Cooper made changes -
        Assignee Matt Cooper [ mattcooper ]
        Gary VanMatre made changes -
        Attachment Window.patch [ 12377009 ]
        Hide
        Gary VanMatre added a comment -

        If the height was not explicitly set, change to "auto" forcing recalculation of the offsetHeight. FireFox doesn't always detect that a PPR has changed the content size.

        Show
        Gary VanMatre added a comment - If the height was not explicitly set, change to "auto" forcing recalculation of the offsetHeight. FireFox doesn't always detect that a PPR has changed the content size.
        Gary VanMatre made changes -
        Attachment Window.patch [ 12377005 ]
        Gary VanMatre made changes -
        Attachment Window.patch [ 12377005 ]
        Hide
        Gary VanMatre added a comment -

        If the height was not explicitly set, change to "auto" forcing recalculation of the offsetHeight. FireFox doesn't always detect that a PPR has changed the content size.

        Show
        Gary VanMatre added a comment - If the height was not explicitly set, change to "auto" forcing recalculation of the offsetHeight. FireFox doesn't always detect that a PPR has changed the content size.
        Gary VanMatre made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Gary VanMatre created issue -

          People

          • Assignee:
            Matt Cooper
            Reporter:
            Gary VanMatre
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development