MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-931

converter and validator 'preferred' metadata needs updating

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.10-core, 1.0.10-core
    • Component/s: None
    • Labels:
      None

      Description

      The preferred metadata for converters an validators is not correct. The meaning of 'preferred' is something that the developer will usually want to set. Currently we don't have 'preferred' on 'maximum' for some of the range validators, but we have it on all the message[*] attrs that generally don't need to be set.

      Here's the metadata I suggest for preferred for converters and validators. If the attr isn't listed it shouldn't have preferred

      af:convertColor (favorite-property = patterns)
      patterns = preferred
      transparentAllowed = preferred

      af:convertDateTime (favorite-property = type)
      dateStyle = preferred
      pattern = preferred
      timeStyle = preferred
      timeZone = preferred
      type = preferred

      af:convertNumber (favorite-property = type)
      integerOnly = preferred
      maxFractionDigits = preferred
      maxIntegerDigits = preferred
      type = preferred
      minFractionDigits = preferred
      minIntegerDigits = preferred
      pattern = preferred
      currencyCode = preferred

      af:validateByteLength (favorite-property = maximum)
      maximum = preferred
      encoding = preferred

      af:validateDateRestriction
      invalidDays = preferred
      invalidDaysOfWeek = preferred
      invalidMonths = preferred

      af:validateDateTimeRange
      maximum = preferred
      minimum = preferred

      af:validateDoubleRange
      maximum=preferred
      minimum = preferred

      af:validateLength
      minimum = preferred
      maximum = preferred

      af:validateLongRange
      minimum = preferred
      maximum = preferred

      af:validateRegExp (favorite-property = pattern)
      pattern = preferred

      1. trunk.patch
        10 kB
        Anita Anandan
      2. trunk12.patch
        9 kB
        Anita Anandan

        Activity

        Hide
        Matthias Weßendorf added a comment -

        For the 1.2 trunk the patch is fine. However not for the JSF 1.1 trunk. Can you please update this ticket with a working patch.

        Show
        Matthias Weßendorf added a comment - For the 1.2 trunk the patch is fine. However not for the JSF 1.1 trunk. Can you please update this ticket with a working patch.
        Hide
        Anita Anandan added a comment -

        Uploaded new Trunk patch on Oct 01, 08

        Show
        Anita Anandan added a comment - Uploaded new Trunk patch on Oct 01, 08

          People

          • Assignee:
            Matthias Weßendorf
            Reporter:
            Gabrielle Crawford
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development