Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-840

New attribute on tr:table to hide Select All/Select None links

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.4-core
    • Fix Version/s: None
    • Component/s: Components
    • Labels:
      None

      Description

      With <tr:table rowSelection="multiple" />, Trinidad will always render links for "Select All" and "Select None" at the top of the table. It would be great to be able to use the multiple row selection, but turn off the Select All/Select None links. For this, I'd suggest a simple new attribute on the table component: selectAllVisible -

      name: selectAllVisible
      type: boolean
      default: true
      required: false

        Activity

        Hide
        darkarena Scott O'Bryan added a comment -

        Version 1.0 is no longer being maintained. If you need this patch, please apply it manually to the trunk-1.0.x branch in trinidad.

        Show
        darkarena Scott O'Bryan added a comment - Version 1.0 is no longer being maintained. If you need this patch, please apply it manually to the trunk-1.0.x branch in trinidad.
        Hide
        dbrunett Dave Brunette added a comment -

        (Hopefully) One last time. This patch also includes the skin selectors documentation update.

        Show
        dbrunett Dave Brunette added a comment - (Hopefully) One last time. This patch also includes the skin selectors documentation update.
        Hide
        dbrunett Dave Brunette added a comment -


        Attaching new patch that uses a skin property instead of adding an attribute to the component

        Show
        dbrunett Dave Brunette added a comment - Attaching new patch that uses a skin property instead of adding an attribute to the component
        Hide
        dbrunett Dave Brunette added a comment -

        Yes, <tr:table rowSelection="multiple" /> works just like it does today, and <tr:table rowSelection="multiple" selectAllVisible="false" /> would not render the links.

        About the same application having some tables with the links, and others without, yes I do think that is a possibility.

        I've already tried to start a discussion on the ML... heard no objections, so I moved ahead on the patch. I'd be happy to go back to the ML if we need...
        http://www.nabble.com/-Trinidad--Enhancement-to-hide-Select-All-Select-None-on-table--tf4852066.html#a13883312

        Show
        dbrunett Dave Brunette added a comment - Yes, <tr:table rowSelection="multiple" /> works just like it does today, and <tr:table rowSelection="multiple" selectAllVisible="false" /> would not render the links. About the same application having some tables with the links, and others without, yes I do think that is a possibility. I've already tried to start a discussion on the ML... heard no objections, so I moved ahead on the patch. I'd be happy to go back to the ML if we need... http://www.nabble.com/-Trinidad--Enhancement-to-hide-Select-All-Select-None-on-table--tf4852066.html#a13883312
        Hide
        matzew Matthias Weßendorf added a comment -

        ya, move this please to ML.
        Jira discussion are odd

        Show
        matzew Matthias Weßendorf added a comment - ya, move this please to ML. Jira discussion are odd
        Hide
        lothian Simon Lessard added a comment -

        I don't know if this should be on component level or a skin property. Is it probable that a given application contains both tr:table with and without the selectAll links? It seems a little like an user interface inconsistency to me. Shouldn't we raise that issue to the dev mailing list and see what people have to say about it?

        Show
        lothian Simon Lessard added a comment - I don't know if this should be on component level or a skin property. Is it probable that a given application contains both tr:table with and without the selectAll links? It seems a little like an user interface inconsistency to me. Shouldn't we raise that issue to the dev mailing list and see what people have to say about it?
        Hide
        matzew Matthias Weßendorf added a comment -

        So,

        <tr:table rowSelection="multiple">... will render the links (like today)
        and <tr:table rowSelection="multiple" selectAllVisible="false" >... will not render the links

        Show
        matzew Matthias Weßendorf added a comment - So, <tr:table rowSelection="multiple">... will render the links (like today) and <tr:table rowSelection="multiple" selectAllVisible="false" >... will not render the links
        Hide
        dbrunett Dave Brunette added a comment -


        Tested this with table_selection.jspx in the demo app. Seems to work fine.

        Show
        dbrunett Dave Brunette added a comment - Tested this with table_selection.jspx in the demo app. Seems to work fine.

          People

          • Assignee:
            darkarena Scott O'Bryan
            Reporter:
            dbrunett Dave Brunette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development