MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-792

Making Reorder,Remove ChildComponentChange generic to all the attributes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.3-core
    • Fix Version/s: 1.0.4-core
    • Component/s: Components
    • Labels:
      None

      Description

      This is to avoid the requirement that " id attribute should always be specified for the children' in case of RemoveChildComponentChange, ReorderChildrenComponentChange.

      This makes the user to always specify 'id' attribute explicitly on the children. This leads to an increase of html output. Instead they can have custom attribute on the component. The users will have to pass custom attribute's value and custom attribute's name to the RemoveChildComponentChange's constructor.

      1. trunk.patch
        10 kB
        shafi khan

        Activity

        Matthias Weßendorf made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Matthias Weßendorf made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.0.4-core [ 12312810 ]
        Resolution Fixed [ 1 ]
        Hide
        Matthias Weßendorf added a comment -

        applied fix to trunk, since it is generic and not specific to a particular JSF version.

        Thanks to Shafi Khan for his patch!

        Show
        Matthias Weßendorf added a comment - applied fix to trunk, since it is generic and not specific to a particular JSF version. Thanks to Shafi Khan for his patch!
        Scott O'Bryan made changes -
        Fix Version/s 1.2.3-core [ 12312741 ]
        Hide
        Scott O'Bryan added a comment -

        Hey Shafi, 1.2.3-core has been release meaning we can't really change it. Is this a change that is specific to the 1.2 branch or is this something that we should commit to trunk?

        Show
        Scott O'Bryan added a comment - Hey Shafi, 1.2.3-core has been release meaning we can't really change it. Is this a change that is specific to the 1.2 branch or is this something that we should commit to trunk?
        Scott O'Bryan made changes -
        Assignee Matthias Weßendorf [ matzew ] Scott O'Bryan [ darkarena ]
        Matthias Weßendorf made changes -
        Assignee Matthias Weßendorf [ matzew ]
        shafi khan made changes -
        Attachment trunk.patch [ 12368826 ]
        Hide
        shafi khan added a comment -

        Patch is provided for this. Now new constructors are supported on RemoveChildComponentChange and ReorderChildrenComponentChange.

        Show
        shafi khan added a comment - Patch is provided for this. Now new constructors are supported on RemoveChildComponentChange and ReorderChildrenComponentChange.
        shafi khan made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        shafi khan created issue -

          People

          • Assignee:
            Scott O'Bryan
            Reporter:
            shafi khan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development