MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-467

Need a warning if someone has .p_AF* styleclass in their skin css file.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 1.0.1-incubating-core-SNAPSHOT, 1.0.1-core, 1.2.1-core, 2.0.0-alpha
    • Component/s: Portlet
    • Labels:
      None

      Description

      If the skinning file has a skinning key with a pseudo-class that is not a CSS-2 pseudo-class (e.g., :read-only, :required), then it gets converted to a styleclass that starts with ".p_AF" (e.g., .p_AFReadOnly, .p_AFRequired)and it does not get put in the compression style map. This is exactly what we want because client-side code can add/remove the 'state' styleclass when the state changes, and if it was compressed they would have to send all states to with their compression equivalent to the client, which adds content.

      This all works fine. If someone creates a skin css file and uses .p_AFReadOnly instead of :read-only, then ".p_AFReadOnly" gets put into the compressed styleclass map and it gets compressed when it is written to the html, and the clients add/remove code no longer works.

      Add some sort of protection against this like a warning message at least.

        Activity

        Hide
        Scott O'Bryan added a comment -

        This still appears to be a valid issue but is a very low priority. It's been around since Trinidad was in incubation.

        Show
        Scott O'Bryan added a comment - This still appears to be a valid issue but is a very low priority. It's been around since Trinidad was in incubation.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jeanne Waldman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development