MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-417

Add Support for Chart component in the trinidad set of components

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-incubating-core
    • Fix Version/s: 1.0.0-incubating-core
    • Component/s: Archetype
    • Labels:
      None
    • Environment:
      Desktop, Browsers Gecko, IE, Opera

      Description

      Add support for a Chart component in the trinidad set of components. This support includes chartTypes: verticalBar, horizontalBar, stackedVerticalBar, stackedHorizontalBar, pie, area, stackedArea, line, barLine combo, XYLine, scatterPlot, radar, radarArea, funnel, circularGauge, semCircularGauge. There will also be support for animation, skinning, tooltips, drilldown, PPR etc. IE, Gecko and Opera platforms will be initially supported.

      1. trunk5.patch
        457 kB
        Venkata Guddanti

        Activity

        Hide
        Venkata Guddanti added a comment -

        Added the initial implementation as a patch. Will work on better documentation and supply that as a future patch. Any suggestions for improvement are very welcome.

        Show
        Venkata Guddanti added a comment - Added the initial implementation as a patch. Will work on better documentation and supply that as a future patch. Any suggestions for improvement are very welcome.
        Hide
        Venkata Guddanti added a comment -

        I looked at the patch files(golden files and noticed that I messed up in the chartModel class. I forgot to put static on the static class initialization block. This was making the series colors grow for every instance of the class. Please use the new trunk patch

        Show
        Venkata Guddanti added a comment - I looked at the patch files(golden files and noticed that I messed up in the chartModel class. I forgot to put static on the static class initialization block. This was making the series colors grow for every instance of the class. Please use the new trunk patch
        Hide
        Adam Winer added a comment -

        I tried to commit this patch, but while testing,chart.jspx just reported an error on Tomcat:

        javax.servlet.ServletException: /components/chart.jspx(34,50) Unable to find setter method for attribute: yMajorCount
        javax.faces.webapp.FacesServlet.service(FacesServlet.java:152)
        org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._invokeDoFilter(TrinidadFilterImpl.java:327)
        org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:291)
        org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:214)
        org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:90)
        org.apache.myfaces.trinidaddemo.webapp.RedirectFilter.doFilter(RedirectFilter.java:95)

        Also, before committing it, it'd be very helpful if you could do an API review on adffaces-dev.

        Show
        Adam Winer added a comment - I tried to commit this patch, but while testing,chart.jspx just reported an error on Tomcat: javax.servlet.ServletException: /components/chart.jspx(34,50) Unable to find setter method for attribute: yMajorCount javax.faces.webapp.FacesServlet.service(FacesServlet.java:152) org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._invokeDoFilter(TrinidadFilterImpl.java:327) org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:291) org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:214) org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:90) org.apache.myfaces.trinidaddemo.webapp.RedirectFilter.doFilter(RedirectFilter.java:95) Also, before committing it, it'd be very helpful if you could do an API review on adffaces-dev.
        Hide
        Venkata Guddanti added a comment -

        I did not test the component in Tomcat. I only tested OC4J. I will test it out in Tomcat and also post the API review in ADF-Faces dev this evening.

        Thanks

        Show
        Venkata Guddanti added a comment - I did not test the component in Tomcat. I only tested OC4J. I will test it out in Tomcat and also post the API review in ADF-Faces dev this evening. Thanks
        Hide
        Venkata Guddanti added a comment -

        There was a bug somewhere in the plugins. It does not accept attributes which has only the first character as lowercase. For e.g. yMajorCount, xMajorCount, yMinorCount. Renamed these attributes to verticalMajorCount, verticalMinorCount, horizontalMajorCount. Also sent out the API for review. Here is a new patch. This one works well on Tomcat

        Show
        Venkata Guddanti added a comment - There was a bug somewhere in the plugins. It does not accept attributes which has only the first character as lowercase. For e.g. yMajorCount, xMajorCount, yMinorCount. Renamed these attributes to verticalMajorCount, verticalMinorCount, horizontalMajorCount. Also sent out the API for review. Here is a new patch. This one works well on Tomcat
        Hide
        Venkata Guddanti added a comment -

        Made all the changes recommended by Adam. Attached is a patch with the latest changes.

        Show
        Venkata Guddanti added a comment - Made all the changes recommended by Adam. Attached is a patch with the latest changes.
        Hide
        Venkata Guddanti added a comment -

        Path that works with the latest changes in rendering APIs. Also added documentation for the chart component.

        Show
        Venkata Guddanti added a comment - Path that works with the latest changes in rendering APIs. Also added documentation for the chart component.
        Hide
        Adam Winer added a comment -

        Checked in patch. The component looks very cool!

        I'll try to do a more detailed impl review, etc., maybe tweak an API here and there, now that it's checked in, but I wanted to stop bit-rot before the patch got out-of-date again.

        Show
        Adam Winer added a comment - Checked in patch. The component looks very cool! I'll try to do a more detailed impl review, etc., maybe tweak an API here and there, now that it's checked in, but I wanted to stop bit-rot before the patch got out-of-date again.

          People

          • Assignee:
            Unassigned
            Reporter:
            Venkata Guddanti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development