[TRINIDAD-2105] DocumentRenderer.encodeAll must not assume root StateManager is Trinidad's

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.0-core
• Component/s: Portlet
• Assignee: Unassigned
• Reporter: Michael Freedman
• Created: 26/May/11 21:25
• Updated: 26/May/11 21:25

Description

DocumentRenderer.encodeAll has the following code:

StateManager sm = context.getApplication().getStateManager();

if (sm instanceof StateManagerImpl)

{ // do real work }

else

{ // log error and return }

This means Trinidad fails in an environment in which its wrapped – such as the Portlet Bridge – even though its StateManager is in use. Instead the code should test for whether its StateManagerImpl and if not recursively test to see if its a StateManagerWrapper. For each wrapper it finds it calls .getWrapped and runs the test again.