MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-1877

visitTree API issues for UIXIterator (stamping components) in Trinidad and Trunk


    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.12-core
    • Fix Version/s: 1.2.14-core
    • Component/s: None
    • Labels:
    • Environment:


      There are different implementations of visitTree API in Trinidad Trunk and 1.2.12.x. Both implementations have problems with visiting the children of 'stamping' components (UIXIterator, UIXTable, UIXTree, etc).

      For example in branch a PPRed stamped child of a UIXIterator can fail to render (never gets visited during encoding) because visitTree never establishes the parent component's 'currency' before visiting the children.

      In Trunk, the UIXIterator's implementation of visitTree assumes that the direct children of UIXIterator are always non-stamped columns and skips over visiting the direct children (goes directly to grand-children) when visiting stamped children. This assumption is incorrect for UIXIterator (when component is not a UIXTable/UIXTreeTable).

      Attaching a proposed fix to address the issue in The patch overrides the visitTree API in UIXIterator and establishes the correct 'currency' before visiting the children of UIXIterator. Appreciate a review and feedback.

      1. visitTree1.patch
        5 kB
        Kamran Kashanian


        Matt Cooper made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Matt Cooper [ mattcooper ]
        Fix Version/s 1.2.14-core [ 12314551 ]
        Resolution Fixed [ 1 ]
        Kamran Kashanian made changes -
        Attachment visitTree.patch [ 12451538 ]
        Kamran Kashanian made changes -
        Attachment visitTree1.patch [ 12453610 ]
        Kamran Kashanian made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Kamran Kashanian made changes -
        Field Original Value New Value
        Attachment visitTree.patch [ 12451538 ]
        Kamran Kashanian created issue -


          • Assignee:
            Matt Cooper
            Kamran Kashanian
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: