Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-1877

visitTree API issues for UIXIterator (stamping components) in Trinidad 1.2.12.3 and Trunk

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.12-core
    • Fix Version/s: 1.2.14-core
    • Component/s: None
    • Labels:
      None
    • Environment:
      All

      Description

      There are different implementations of visitTree API in Trinidad Trunk and 1.2.12.x. Both implementations have problems with visiting the children of 'stamping' components (UIXIterator, UIXTable, UIXTree, etc).

      For example in 1.2.12.3 branch a PPRed stamped child of a UIXIterator can fail to render (never gets visited during encoding) because visitTree never establishes the parent component's 'currency' before visiting the children.

      In Trunk, the UIXIterator's implementation of visitTree assumes that the direct children of UIXIterator are always non-stamped columns and skips over visiting the direct children (goes directly to grand-children) when visiting stamped children. This assumption is incorrect for UIXIterator (when component is not a UIXTable/UIXTreeTable).

      Attaching a proposed fix to address the issue in 1.2.12.3. The patch overrides the visitTree API in UIXIterator and establishes the correct 'currency' before visiting the children of UIXIterator. Appreciate a review and feedback.

        Attachments

        1. visitTree1.patch
          5 kB
          Kamran Kashanian

          Activity

            People

            • Assignee:
              mattcooper Matt Cooper
              Reporter:
              kamrankashanian Kamran Kashanian
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: