Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha-2
    • Fix Version/s: 2.0.0-beta-1
    • Component/s: Components
    • Labels:
      None

      Description

      The subform is setting a value on its facesBean to determine if it's the submitted subform.
      See org.apache.myfaces.trinidad.component.UIXSubform.setSubmitted()

      So when the subform is stamped, the value of the last row wins, since that's the final value saved to the facesBean. That means if you submit the last row everything is considered submitted, if you submit from other rows nothing is saved.

      1. 1849.patch
        11 kB
        Gabrielle Crawford

        Activity

        Gabrielle Crawford created issue -
        Hide
        Gabrielle Crawford added a comment -

        There's a related spec issue for this too
        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=153

        We work around similar issues for things like showDetail and inputs in an iterator by special casing saving their state in a method _createState.

        However submitted in a subform is really request scope, and shouldn't be saved to the facesBean at all, instead we should save this info on a request property.

        Show
        Gabrielle Crawford added a comment - There's a related spec issue for this too https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=153 We work around similar issues for things like showDetail and inputs in an iterator by special casing saving their state in a method _createState. However submitted in a subform is really request scope, and shouldn't be saved to the facesBean at all, instead we should save this info on a request property.
        Hide
        Gabrielle Crawford added a comment -

        Changing to using a request property instead of the faces bean to store 'submitted' means deprecating the 'submitted propertyKey.

        Show
        Gabrielle Crawford added a comment - Changing to using a request property instead of the faces bean to store 'submitted' means deprecating the 'submitted propertyKey.
        Gabrielle Crawford made changes -
        Field Original Value New Value
        Attachment 1849.patch [ 12449301 ]
        Gabrielle Crawford made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0.3-core [ 12314840 ]
        Resolution Fixed [ 1 ]
        Hide
        Gabrielle Crawford added a comment -

        This has broken the behavior of the default attribute, see
        https://issues.apache.org/jira/browse/TRINIDAD-1943

        Show
        Gabrielle Crawford added a comment - This has broken the behavior of the default attribute, see https://issues.apache.org/jira/browse/TRINIDAD-1943
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 22h 23m 1 Gabrielle Crawford 16/Jul/10 21:44

          People

          • Assignee:
            Gabrielle Crawford
            Reporter:
            Gabrielle Crawford
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development