[TRINIDAD-1714] Mark the skin as dirty if DesignTime mode and org.apache.myfaces.trinidad.skin.id is set.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.14-core
• Assignee: Jeanne Waldman
• Reporter: Jeanne Waldman
• Created: 09/Feb/10 00:26
• Updated: 09/Feb/10 19:45
• Resolved: 09/Feb/10 19:45

Description

Our Design Time team wasn't satisfied with "TRINIDAD-1637 always check for file modification if in DesignTime mode regardless of web.xml setting".
Instead, they'd rather if we always update the skin. Since we now have the skin.isDirty/setDirty apis, we can use those.

The fix for this is in StyleContextImpl. Revert the change for 1637 and in StyleContextImpls's isDirty, return true if DesignTime mode && flag is set. Also, in this case, setDirty to true on the skin in case someone is checking the skin instead of the StyleContext.

Also, in FileSystemStyleCache, instead of calling skin.isDirty, call styleContext.isDirty like I should have done in the first place.