MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-1714

Mark the skin as dirty if DesignTime mode and is set.


    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.14-core
    • Component/s: None
    • Labels:


      Our Design Time team wasn't satisfied with "TRINIDAD-1637 always check for file modification if in DesignTime mode regardless of web.xml setting".
      Instead, they'd rather if we always update the skin. Since we now have the skin.isDirty/setDirty apis, we can use those.

      The fix for this is in StyleContextImpl. Revert the change for 1637 and in StyleContextImpls's isDirty, return true if DesignTime mode && flag is set. Also, in this case, setDirty to true on the skin in case someone is checking the skin instead of the StyleContext.

      Also, in FileSystemStyleCache, instead of calling skin.isDirty, call styleContext.isDirty like I should have done in the first place.


        Jeanne Waldman created issue -
        Jeanne Waldman made changes -
        Field Original Value New Value
        Attachment 1714patchfor12122.patch [ 12435328 ]
        Jeanne Waldman made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.14-core [ 12314551 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        19h 19m 1 Jeanne Waldman 09/Feb/10 19:45


          • Assignee:
            Jeanne Waldman
            Jeanne Waldman
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: