Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 1.0.0-incubating-core
    • Fix Version/s: 1.0.0-incubating-core
    • Component/s: None
    • Labels:
      None

      Description

      The showRequired attribute is currently broken as implemented in trunk. I noticed it on components base on the class
      org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.LabelAndMessageRenderer

      1st issue is the labelShowRequired() method ORing || both the required and showRequired flag making the second one useless in case required is true. I would recommend changing the conditional to && and setting the default value for showRequired to true.

        Activity

        Hide
        Adam Winer added a comment -

        The purpose of showRequired is not to turn off display of the required icon, it's to turn it on for fields that aren't strictly required. What you're recommending would break that. You can use skinning to remove required icons in general. If you're looking for a way to turn it off for a field that is required on a per-instance basis, then that would be an enhancement request, not a bug.

        Show
        Adam Winer added a comment - The purpose of showRequired is not to turn off display of the required icon, it's to turn it on for fields that aren't strictly required. What you're recommending would break that. You can use skinning to remove required icons in general. If you're looking for a way to turn it off for a field that is required on a per-instance basis, then that would be an enhancement request, not a bug.

          People

          • Assignee:
            Unassigned
            Reporter:
            Stefan Podkowinski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development