MyFaces Trinidad
  1. MyFaces Trinidad
  2. TRINIDAD-1276

Force usage of javac in JDK 1.5 if trying to build Trinidad using Java6 or Java7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.9-core, 1.2.9-core
    • Fix Version/s: 1.2.10-core, 1.0.10-core
    • Component/s: Build
    • Labels:
      None

      Description

      Right now the maven build will happily compile Java6 or later code if the user runs the build using java6 or java7. This creates problems as contributors can get code into Trinidad that will not compile on Java5. Using source & target are not enough as this will not pick up things like methods that are new for example.

        Activity

        Hide
        Andrew Robinson added a comment -

        Committed & tested on linux & windows.

        Note that on windows, the JDK path must not have spaces due to a maven bug. See the WIKI for more information

        http://wiki.apache.org/myfaces/Building_Trinidad_With_Maven

        Show
        Andrew Robinson added a comment - Committed & tested on linux & windows. Note that on windows, the JDK path must not have spaces due to a maven bug. See the WIKI for more information http://wiki.apache.org/myfaces/Building_Trinidad_With_Maven
        Hide
        Andrew Robinson added a comment -

        Updated the WIKI with this information:
        http://wiki.apache.org/myfaces/Building_Trinidad_With_Maven

        Show
        Andrew Robinson added a comment - Updated the WIKI with this information: http://wiki.apache.org/myfaces/Building_Trinidad_With_Maven
        Hide
        Andrew Robinson added a comment -

        This change will force people compiling Trinidad on Java6 or Java7 to have a "jdk5.home" property set. Here is an example settings.xml of how to set this property:

        <settings>
        <profiles>
        <profile>
        <id>java5.home</id>
        <activation>
        <activeByDefault>true</activeByDefault>
        </activation>
        <properties>
        <jdk5.home>/usr/lib/jvm/java-1.5.0-sun</jdk5.home>
        </properties>
        </profile>
        </profiles>
        </settings>

        Show
        Andrew Robinson added a comment - This change will force people compiling Trinidad on Java6 or Java7 to have a "jdk5.home" property set. Here is an example settings.xml of how to set this property: <settings> <profiles> <profile> <id>java5.home</id> <activation> <activeByDefault>true</activeByDefault> </activation> <properties> <jdk5.home>/usr/lib/jvm/java-1.5.0-sun</jdk5.home> </properties> </profile> </profiles> </settings>

          People

          • Assignee:
            Andrew Robinson
            Reporter:
            Andrew Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development