[TRINIDAD-1185] Problems with the iterator implementation in RowSetTreeImpl class

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.9-core
• Fix Version/s: 1.2.10-core, 1.0.10-core
• Component/s: Components
• Assignee: Matthias Wessendorf
• Reporter: Kamran Kashanian
• Created: 19/Aug/08 19:58
• Updated: 27/Jan/10 08:45
• Resolved: 20/Aug/08 20:09

Description

The iterator implementation (PathIterator) in the Trinidad RowKeySetTreeImpl class has the following problems:

1) It loops over the tree model even if the set is empty
2) It loops over the tree model even if the set contains no "default contained" nodes. "Default contained" nodes are "Expand All", "Select All", "Expand All Below", etc nodes.

For large tree models, unnecessary looping over the tree model can be expensive, since it can force the model to perform additional data fetches (beyond what is currently displayed in the view port on the client).

The attached patch provides a new iterator implementation called NodeIterator, which extends the current PathIterator and avoids unnecessary looping over the tree model. NodeIterator loops over the model only if it encounters "default contained" nodes in the set.