[TRAFODION-3139] Remove more obsolete cruft from parser and other modules

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.3
• Component/s: sql-cmp
• Assignee: Dave Birdsall
• Reporter: Dave Birdsall
• Created: 12/Jul/18 01:11
• Updated: 12/Jul/18 01:11

Description

In Jira TRAFODION-3135, I removed some obsolete references to a predecessor product from parser/ParKeyWords.cpp and common/ComResWords.cpp.

There are additional references to that product in many other modules. Much obsolete code could be removed, simplifying maintenance of the product.

Examples include:

In parser/sqlparser.y: Productions MP_nonreserved_word and MP_nonreserved_func_word could be removed, along with anything that refers to a "guardian" location or to "sql_mp". (Note: When removing the MP_nonreserved_* productions, take care that the keywords OLD and NEW remain non-reserved in most contexts. Yes, I tried this with the earlier JIRA.) Also, the CREATE CATALOG and related commands are presently stubbed; their productions sometimes make reference to these "guardian" concepts; perhaps these can be stubbed even further.

The common/ComMPLoc.h and .cpp modules refer to a NonStop Kernel file system location. These can be removed, along with all code referencing such objects. There are a handful of such places sprinkled around the compiler.

A general search for "SQL/MP" may reveal more such opportunities.