Major Description
Selva pointed me to this leak. He found that we leak GroupAttributes objects in the metadata context.
It turns out that the ControlDB object makes copies of CQD and CQS RelExpr trees and stores them in the context heap. This is not a good idea, since RelExpr and the associate GroupAttributes classes are not designed for heaps other than the statement heap. GroupAttributes, for example, hard-codes the statement heap in its constructor calls to ValueIdSets. That probably isn't a visible problem in ControlDB, however.
For CQDs, the allocations and deallocations seem to match. For CQS, we allocate ControlQueryShape objects and also the actual shapes. However, we deallocate only the ControlQueryShape objects, not the shapes themselves.
A simple, conservative fix is therefore to deallocate the shapes as well. In the longer term, it would be good to avoid storing RelExprs in the context heap.
Attachments
Issue Links
- links to
