Torque
  1. Torque
  2. TORQUE-57

escapeText() method in DBOracle returns false but escape characters are required in Oracle in certain cases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: Runtime
    • Labels:
      None
    • Environment:
      All OS, All hardware, Oracle Data base

      Description

      Oracle uses escape characters for interpreting certain special characters like "_" literally. However the escapeText() method in
      org.apache.torque.adapter.DBOracle class returns false. The value returned by this method is used by the SqlExpression.quoteAndEscape method. As the escapeText method returns false a where clause condition: like 'abc_%' will get translated to: like 'abc%' (note the missing "_") in the SQLExpression.buildLike method. Sybase and SQL Server also has the same Escape behavior but the escapeText() method in DBSybase and DBMSSQL returns true.

      Below is a copy of the source code in DBOracle.
      /**

      • This method is for the SqlExpression.quoteAndEscape rules. The rule is,
      • any string in a SqlExpression with a BACKSLASH will either be changed to
      • "
        " or left as "\". SapDB does not need the escape character.
        *
      • @return false.
        */
        public boolean escapeText() { return false; }

      The usecase I am trying out is one where a column in the table queried has values 'abc' and 'a_c'. I need to query the record that has the column value as 'a_c'. If I issue a query without escapecharacters (where <column> like 'a_%' ) both the rows are returned. I need to provide a where clause with the condition as <column> like 'a_%' to get the correct record (also need to add ESCAPE keyword to the query). However, because escapeText returns false, the criteria value gets built wrongly in the buildLike method of SQLExpression class.. (the method returns 'a%'). If escapeText returns true this problem will be solved (ESCAPE keyword addition needs to be tackled separately also).

      information regarding escape characters in Oracle http://www.dba-oracle.com/tips_oracle_escape_characters.htm

        Activity

          People

          • Assignee:
            Thomas Fox
            Reporter:
            parthasarathy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development