Torque
  1. Torque
  2. TORQUE-42

Criteria.andDate missing getTime() method call

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: Runtime
    • Labels:
      None
    • Environment:
      java5, tomcat 5.5.17

      Description

      Hello all,

      there is a bug in Criteria.andDate: the call to the method getTime() is missing while it is present in Criteria.addDate

      To exploit it use a code like

      calendar.setTime(new Date());
      crit.addDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH), calendar.get(Calendar.DAY_OF_MONTH), Criteria.GREATER_EQUAL);

      calendar.add(Calendar.DAY_OF_MONTH, 1);
      crit.andDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH), calendar.get(Calendar.DAY_OF_MONTH), Criteria.LESS_THAN);

      This leads to a SQLException due to incorrect sql query creation.
      That is easy to see with Criteria.toString()

      Adding the missing method call solves the problem

      Please, check the attached patch. Thank you

      1. Criteria-3.2.patch
        0.8 kB
        Federico Fissore

        Activity

        Federico Fissore created issue -
        Federico Fissore made changes -
        Field Original Value New Value
        Attachment Criteria-3.2.patch [ 12336727 ]
        Thomas Vandahl made changes -
        Assignee Thomas Vandahl [ tv ]
        Hide
        Thomas Vandahl added a comment -

        Fixed in SVN

        Show
        Thomas Vandahl added a comment - Fixed in SVN
        Thomas Vandahl made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 3.2.1 [ 12310991 ]
        Fix Version/s 3.2 [ 12310881 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Thomas Vandahl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 9h 29m 1 Thomas Vandahl 14/Jul/06 04:59
        Resolved Resolved Closed Closed
        135d 14h 24m 1 Thomas Vandahl 26/Nov/06 18:23

          People

          • Assignee:
            Thomas Vandahl
            Reporter:
            Federico Fissore
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development