[TORQUE-368] MySQL/MariaDb Column Default not set in generated sql for empty string

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1, 6.0
• Fix Version/s: 7.0
• Component/s: Generator, Templates
• Assignee: Max Philipp Wriedt
• Reporter: Max Philipp Wriedt
• Created: 16/Oct/24 10:15
• Updated: 23/Nov/24 15:17
• Resolved: 23/Nov/24 15:17

Description

Example XML:

<table name="feiertag" javaName="Holiday">
    <column name="id"           primaryKey="true"       type="INTEGER"                           required="true"/>
    <column name="datum"        javaName="Date"         type="BIGINT"                default="0"  required="true"/>
    <column name="name"         javaName="Name"         type="VARCHAR"   size="150"  default=""   required="true"/>
    <column name="zuschlag"     javaName="Bonus"        type="CHAR"      size="1"    default="N"  required="true"/>
    <column name="bundesland"   javaName="State"        type="VARCHAR"   size="2"    default=""   required="true"/>

    <unique name="dateunique"><unique-column name="datum"/></unique>
</table> 

Generates SQL:

CREATE TABLE feiertag(    
    id INTEGER NOT NULL AUTO_INCREMENT,
    datum BIGINT default 0 NOT NULL,
    name VARCHAR(150) NOT NULL,
    zuschlag CHAR(1) default 'N' NOT NULL,
    bundesland VARCHAR(2) NOT NULL,
    PRIMARY KEY(id),
    UNIQUE dateunique (datum)
); 

As you can see, the VARCHAR name and the VARCHAR bundesland are correctly defined a "NOT NULL". The 

default=""

is ignored.

This wasn't a problem until NO_ENGINE_SUBSTITUTION was set as default in MySQL 5.6  & MariaDb 10.1.7 

I wasn't able to find the corresponding generation for the DEFAULT value inside the template or the generator.

Also: should we make this switchable, i.e. if default tag is present, always generate a DEFAULT or if default tag is present but empty, leave it out completely?