Uploaded image for project: 'Torque'
  1. Torque
  2. TORQUE-153

Fail if null connection is supplied to a method

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-beta1
    • Runtime
    • None

    Description

      Current behaviour: Methods with a connection argument silently fetch a new connection if the passed connection is null
      New behaviour: These methods should throw an exception if the passed connection is null
      Rationale: these methods will be only needed if a method should be executed in a transaction context. If one assumes that a transaction is open (connection is not null), but it is not (connection == null), it is a bad idea to silently start one as this behaviour is very difficult to tell from the correct one. A clean failure is much easier to test for.

      Attachments

        Activity

          People

            tfischer Thomas Fox
            tfischer Thomas Fox
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: