[TORQUE-108] Criteria addJoin causes incorrect SQL to be generated when optional schema references are in use (Oracle)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3-RC1, 3.3-RC2, 3.3-RC3
• Fix Version/s: 4.0-beta1
• Component/s: Runtime
• Environment: Linux, Java 1.6
• Assignee: Thomas Fox
• Reporter: Brendan Miller
• Created: 04/Feb/08 22:33
• Updated: 24/Oct/15 08:33
• Resolved: 30/Jan/12 18:31

Description

I previously wrote about this to torque-user in Oct 2007.

In a schema definition that includes torque.dsfactory.programs.schema, writing the following

Criteria crit = new Criteria();
crit.addJoin(TransactionPeer.ORDER_ID, OrderPeer.ID);
crit.add(TransactionPeer.ACCT_ID, account.getID());
List<Order> orders = OrderPeer.doSelect(crit);

generates

SELECT <..ORDERS columns..> FROM TRANSACTION, ORDERS, DBSCHEMA.ORDERS, DBSCHEMA.TRANSACTION
WHERE TRANSACTION.ORDER_ID=ORDERS.ID AND TRANSACTION.ACCT_ID= ?

Upon examining the Torque code, it appears that SQLBuilder.processJoins does not add the full table names, while SQLBuilder.processCriterions does.
Shouldn't they both add the full table names?