[TOMEE-3776] WebappBeanManager calls to getInjectionPointBean(injectionPoint) results in UnsatisfiedResolutionException lot of times

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0.6
• Fix Version/s: 8.0.8
• Component/s: TomEE Core Server
• Assignee: Unassigned
• Reporter: Raghunandan
• Created: 17/Jul/21 01:57
• Updated: 19/Oct/22 10:49
• Resolved: 19/Oct/22 10:49

Description

Issue  We are using TomEE1.7.4 and we are trying to upgrade to TomEE8.0.6.

We are seeing WebappBeanManager calls getInjectionPointBean results in lot of UnsatisfiedResolutionException  where in TomEE.1.7.4  there are no such exceptions.

UnsatisfiedResolutionException  is not an issue but leads to thread blocking issue due to an issue in openwebbeans.

Our functionality works fine as the it finds the bean somewhere else but we get a performance issue due to repeated UnsatisfiedResolutionException thrown by openwebbeans code.

Observation: 

https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/cdi/WebappBeanManager.java

 We observed WebappBeanManager code is making some redundant call to with parentBm.getInjectionResolver().getInjectionPointBean(injectionPoint) resulting some in UnsatisfiedResolutionException but application works fine but we get in to thread blocking issues due to this exception from openwebbeans.

 Openwebbeans issue (https://issues.apache.org/jira/browse/OWB-1388)* : 

It has a instance variable with making System.Property call which calls java.util.HashTable (synchronized get method) causing threads to block.

 private final String lineSeparator = System.getProperty("line.separator");

 

Change requested:

Either fix the WebappBeanManager class so that UnsatisfiedResolutionException is avoided when everything works fine.    

Or

Once OWB-1388 is fixed please patch with TomEE 8.0.6. If exception can't be avoided then at at least threads will not be blocked causing a significant performance issue.

 

 

Issue Links

• relates to: OWB-1388 ViolationMessageBuilder has System.getProperty call as instance variable rather than static variable