[TOMEE-1832] dbcp2 datasource lock contention on createDataSource + illogical locking

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.1
• Assignee: Romain Manni-Bucau
• Reporter: Romain Manni-Bucau
• Created: 07/Jun/16 15:16
• Updated: 07/Jun/16 15:18
• Resolved: 07/Jun/16 15:18

Description

We extend dbcp(2) datasource to add some custom features like password ciphering etc...

We need to ensure locking is consistent (ie we dont use our own locking when parent uses synchronized) + createDataSource should absolutely avoid locking as much as possible at runtime (as its parent)

Side note: normally it is not a high requirement to synchronize getters/setters (parent doesnt) but worse case it doesn't hurt there if we want to do runtime modification later