TomEE
  1. TomEE
  2. TOMEE-165

Stateful bean capacity config should have a more manageable default

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-beta-2
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, in tomee.xml, the stateful bean capacity is defaulted to 1000 which is usually a high number and can burn unsuspecting users. One suggestion is to cap it ~10.

      1. tomee-165.patch
        0.5 kB
        Gaurav Sharma

        Activity

        Gaurav Sharma created issue -
        Gaurav Sharma made changes -
        Field Original Value New Value
        Attachment tomee-165.patch [ 12524349 ]
        Hide
        Gaurav Sharma added a comment -

        Attached a patch, ran all core tests (green):
        Tests run: 3490, Failures: 0, Errors: 0, Skipped: 0

        Show
        Gaurav Sharma added a comment - Attached a patch, ran all core tests (green): Tests run: 3490, Failures: 0, Errors: 0, Skipped: 0
        Hide
        Romain Manni-Bucau added a comment -

        Hi,

        IMHO 10 is not enough, we should follow at the minimum the request pool i guess (200 by default). Finally 1000 was maybe not so bad.

        Romain

        Show
        Romain Manni-Bucau added a comment - Hi, IMHO 10 is not enough, we should follow at the minimum the request pool i guess (200 by default). Finally 1000 was maybe not so bad. Romain
        Hide
        Gaurav Sharma added a comment -

        Since y'all have more experience with how users are using it, I will defer to you for defaults. I think it might be better to ship with a sensible default. Users can up it if needed. I made it 10 based off of David's suggestion yesterday of 4 or 10 but open to changing. 1000 is definitely quite high imho.

        Show
        Gaurav Sharma added a comment - Since y'all have more experience with how users are using it, I will defer to you for defaults. I think it might be better to ship with a sensible default. Users can up it if needed. I made it 10 based off of David's suggestion yesterday of 4 or 10 but open to changing. 1000 is definitely quite high imho.
        Hide
        Romain Manni-Bucau added a comment -

        we can definitely discuss about it.

        here my thought:

        a stateful can be used across several requests so if the tomee is used at its maximum (200 users) it means 200 statefuls at the same moment and potentially multiple flows.

        That's why 1000 seems fine for me.

        Show
        Romain Manni-Bucau added a comment - we can definitely discuss about it. here my thought: a stateful can be used across several requests so if the tomee is used at its maximum (200 users) it means 200 statefuls at the same moment and potentially multiple flows. That's why 1000 seems fine for me.
        David Blevins made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Gaurav Sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development