[TOMEE-1401] Invalid module lookup of OpenEJBDeploymentManager

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Auto Closed
• Affects Version/s: 7.0.0
• Assignee: Unassigned
• Reporter: Daniel Kasmeroglu
• Created: 13/Oct/14 01:14
• Updated: 17/May/23 18:35
• Resolved: 17/May/23 18:35

Description

There is an error in the following methods:

• getAvailableModules
• getRunningModules
• getNonRunningModules

The error makes the parameter moduleType useless as it's basically ignored. I suspect that this is the result of an incomplete refactoring attempt.
See:

https://kasisoft.com/stash/projects/TOMEE/repos/tomee/commits/b10129e0f66277e003c7ed9f5912faf1f4c65b78

Apart from that these methods are basically all equal so they could be combined into a single method (I didn't do that to keep the diff readable).