MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-982

SelectOneRow missing disabled and readonly attributes as described in TLD (patch provided)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1.6
    • Fix Version/s: 1.1.7
    • Component/s: None
    • Labels:
      None

      Description

      The SelectOneRow sandbox component does not render the HTML 'disabled' or 'readonly' attributes as specified by the component's TLD documentation. (Source code has a comment indicating that these features have not been implemented.) I needed this functionality so I implemented it. (Patch provided)

      1. SelectOneRow.patch
        4 kB
        Mike Gillan
      2. SelectOneRowRenderer.patch
        7 kB
        Mike Gillan

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        13s 1 Mike Gillan 09/May/07 03:21
        Patch Available Patch Available Resolved Resolved
        477d 17h 27m 1 Leonardo Uribe 28/Aug/08 20:48
        Resolved Resolved Closed Closed
        5d 8h 58m 1 Leonardo Uribe 03/Sep/08 05:46
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.7 [ 12313398 ]
        Fix Version/s 1.1.7-SNAPSHOT [ 12312361 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.7-SNAPSHOT [ 12312361 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Assignee Hazem Saleh [ hazems ] Leonardo Uribe [ lu4242 ]
        Hide
        Leonardo Uribe added a comment -

        I have checked the code and there are two points:

        1. The patch does not take into account the config param org.apache.myfaces.READONLY_AS_DISABLED_FOR_SELECTS.
        2. The readonly parameter is already written, so there is no need to do this again.

        After this, There was committed a solution taking into account this two points.

        thanks for the suggestions

        Show
        Leonardo Uribe added a comment - I have checked the code and there are two points: 1. The patch does not take into account the config param org.apache.myfaces.READONLY_AS_DISABLED_FOR_SELECTS. 2. The readonly parameter is already written, so there is no need to do this again. After this, There was committed a solution taking into account this two points. thanks for the suggestions
        Hazem Saleh made changes -
        Assignee Cagatay Civici [ cagatay_civici ] Hazem Saleh [ hazems ]
        Cagatay Civici made changes -
        Assignee Cagatay Civici [ cagatay_civici ]
        Hide
        Mike Gillan added a comment -

        Sorry for the long delay getting this patch converted. I had to convert our company's source control from CVS to subversion. Please let me know if you have any problems with the new patch.

        Show
        Mike Gillan added a comment - Sorry for the long delay getting this patch converted. I had to convert our company's source control from CVS to subversion. Please let me know if you have any problems with the new patch.
        Mike Gillan made changes -
        Affects Version/s 1.1.6 [ 12312536 ]
        Affects Version/s 1.1.5 [ 12312397 ]
        Hide
        Mike Gillan added a comment -

        Patch updated to work against version 1.1.6

        Show
        Mike Gillan added a comment - Patch updated to work against version 1.1.6
        Mike Gillan made changes -
        Attachment SelectOneRowRenderer.patch [ 12369110 ]
        Hide
        Mike Gillan added a comment -

        Updated patch created with subversion

        Show
        Mike Gillan added a comment - Updated patch created with subversion
        Mike Gillan made changes -
        Attachment SelectOneRow.patch [ 12369109 ]
        Hide
        Mike Gillan added a comment -

        Updated patch created using subversion

        Show
        Mike Gillan added a comment - Updated patch created using subversion
        Mike Gillan made changes -
        Attachment SelectOneRowRenderer.patch [ 12356955 ]
        Mike Gillan made changes -
        Attachment SelectOneRow.patch [ 12356954 ]
        Manfred Geiler made changes -
        Fix Version/s 1.1.5 [ 12312397 ]
        Hide
        Grant Smith added a comment -

        Mike,

        Sorry to be a pain, but could you resubmit the patches using svn diff, please ?

        Show
        Grant Smith added a comment - Mike, Sorry to be a pain, but could you resubmit the patches using svn diff, please ?
        Mike Gillan made changes -
        Component/s selectOneRadio / radio [ 12310771 ]
        Hide
        Mike Gillan added a comment -

        I think I filed this under the wrong component #.# - should be for the Sandbox SelectOneRow component

        Show
        Mike Gillan added a comment - I think I filed this under the wrong component # . # - should be for the Sandbox SelectOneRow component
        Hide
        Mike Gillan added a comment -

        I apologize for my patches - I reformatted the code and as a result the patches look like the overwrite the entire files. Actually only a few lines were added in each case. If you need me to resubmit, please let me know and I'll do so.

        Show
        Mike Gillan added a comment - I apologize for my patches - I reformatted the code and as a result the patches look like the overwrite the entire files. Actually only a few lines were added in each case. If you need me to resubmit, please let me know and I'll do so.
        Mike Gillan made changes -
        Attachment SelectOneRowRenderer.patch [ 12356955 ]
        Hide
        Mike Gillan added a comment -

        Patch for renderer - actually does the work of rendering the necessary HTML attributes for the tag. Used the tomahawk renderer as per the existing source to keep it consistent.

        Show
        Mike Gillan added a comment - Patch for renderer - actually does the work of rendering the necessary HTML attributes for the tag. Used the tomahawk renderer as per the existing source to keep it consistent.
        Mike Gillan made changes -
        Attachment SelectOneRow.patch [ 12356954 ]
        Hide
        Mike Gillan added a comment -

        Patch to SelectOneRow.java to store the Boolean disabled and readonly attributes

        Show
        Mike Gillan added a comment - Patch to SelectOneRow.java to store the Boolean disabled and readonly attributes
        Mike Gillan made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Mike Gillan created issue -

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Mike Gillan
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development