MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-5

newspaperTable should be merged with dataTable.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.3
    • Component/s: Newspaper Table
    • Labels:
      None
    • Environment:
      Windows XP, JBOSS

      Description

      newspaperTable should be merged with dataTable. It should be a property of dataTable.

      <t:dataTable ....
      newspaperColumns="8"/>

      if the property is 0 or not defined, it is a normal table, otherwise render as newspaper.

      This way it can leverage all features of dataTable such as sorting and dynamic column model, etc.

        Issue Links

          Activity

          Hide
          Mike Kienenberger added a comment -

          Ok. I've made a first-pass attempt to merge newspaperTable into t:dataTable.
          This version works for me, but I'm not sure that it supports all of the extended datatable features yet (ie, newspaper columns and details/grouping/sorting in there may not work together, but both should still work separately).

          There were a lot of unexpected changes I had to make to the row style and column style api in order to merge these two together, so it's possible that this patch might break something in there.

          So far, I've been testing it with facelets, so as of yet, there's no jsp tag and tld support – it should be trivial to add it in.

          This is pretty cool in that all you need to do is change t:newspaperTable to t:dataTable, and it "just works"

          Show
          Mike Kienenberger added a comment - Ok. I've made a first-pass attempt to merge newspaperTable into t:dataTable. This version works for me, but I'm not sure that it supports all of the extended datatable features yet (ie, newspaper columns and details/grouping/sorting in there may not work together, but both should still work separately). There were a lot of unexpected changes I had to make to the row style and column style api in order to merge these two together, so it's possible that this patch might break something in there. So far, I've been testing it with facelets, so as of yet, there's no jsp tag and tld support – it should be trivial to add it in. This is pretty cool in that all you need to do is change t:newspaperTable to t:dataTable, and it "just works"
          Hide
          Mike Kienenberger added a comment -

          TODO items: code cleanup, t:dataTable docs, t:dataTable jsp tags, t:dataTable tld tags, note that t:newspaperTable is obsolete, tests to see how newspaper columns work with extended grouping, details, sorting functionality.

          Show
          Mike Kienenberger added a comment - TODO items: code cleanup, t:dataTable docs, t:dataTable jsp tags, t:dataTable tld tags, note that t:newspaperTable is obsolete, tests to see how newspaper columns work with extended grouping, details, sorting functionality.
          Hide
          Mike Kienenberger added a comment -

          Adding JSP tag handler.

          Show
          Mike Kienenberger added a comment - Adding JSP tag handler.
          Hide
          Mike Kienenberger added a comment -

          Added tld attributes.

          Show
          Mike Kienenberger added a comment - Added tld attributes.
          Hide
          sean schofield added a comment -

          If this works are we going to deprecate the whole newspaperTable component? (I'm ok with this btw.) Eventually we should probably add such deprecation warnings to the source and documentation.

          Show
          sean schofield added a comment - If this works are we going to deprecate the whole newspaperTable component? (I'm ok with this btw.) Eventually we should probably add such deprecation warnings to the source and documentation.
          Hide
          Mike Kienenberger added a comment -

          Yes, I see no point in keeping it around.
          Fortunately, deprecation should be as simple as pointing the tld to t:dataTable instead!

          At least in my tests, simplying changing the t:newspaperTable tag to t:dataTable has been sufficient in my pages.

          Show
          Mike Kienenberger added a comment - Yes, I see no point in keeping it around. Fortunately, deprecation should be as simple as pointing the tld to t:dataTable instead! At least in my tests, simplying changing the t:newspaperTable tag to t:dataTable has been sufficient in my pages.
          Hide
          Mike Kienenberger added a comment -

          Fixed.

          Much thanks to Jesse Wilson who provided the original newspaperTable component.

          Show
          Mike Kienenberger added a comment - Fixed. Much thanks to Jesse Wilson who provided the original newspaperTable component.

            People

            • Assignee:
              Mike Kienenberger
              Reporter:
              Dave
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development