MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-366

Server Side Tab Switching in panelTabbedPane not configurable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      all

      Description

      We have code which was working with an earlier version of the MyFaces distribution. This distribution used serverSide tab switching in a panelTabbedPane. The tab switching behaviour in MyFaces-1.1.0 have been changed to client side and there is no configurable way to switch it back to the server side tab switching (except disabling javascript in your browser). Since the server side tab switching functionality is still there in code and it may be desirable to use it in certain circumstances, we have modified HtmlTabbedPaneTag and HtmlTabbedPaneRenderer classes to make the tab switching configurable. Is there a way to add that functionality to the Tomahawk code base. I can provide the modified classes.

      1. attribute.txt
        0.3 kB
        Swarn Dhaliwal
      2. HtmlPanelTabbedPaneTag.java
        6 kB
        Swarn Dhaliwal
      3. HtmlPanelTabbedPaneTag.patch
        1 kB
        Swarn Dhaliwal
      4. HtmlTabbedPaneRenderer.java
        24 kB
        Swarn Dhaliwal
      5. HtmlTabbedPaneRenderer.patch
        2 kB
        Swarn Dhaliwal
      6. myfaces_ext.tld
        417 kB
        Swarn Dhaliwal
      7. tomahawk.tld
        417 kB
        Swarn Dhaliwal

        Activity

        Hide
        Swarn Dhaliwal added a comment -

        File contains fix for the serverside tab switch

        Show
        Swarn Dhaliwal added a comment - File contains fix for the serverside tab switch
        Hide
        Swarn Dhaliwal added a comment -

        contain updates for server side tab switching

        Show
        Swarn Dhaliwal added a comment - contain updates for server side tab switching
        Hide
        Mike Kienenberger added a comment -

        Swarn,

        Thanks for the patch! Several users have requested this functionality, but no one had provided patches.

        However, can you resubmit it in patch format? It's not possible to replace whole files as other changes may occur in the meantime.

        Here's one resource on how to create patches.

        http://james.apache.org/contribute.html

        I can also provide specific help for creating patches from Eclipse if you need it. Feel free to email me directly at mkienenb@gmail.com.

        Show
        Mike Kienenberger added a comment - Swarn, Thanks for the patch! Several users have requested this functionality, but no one had provided patches. However, can you resubmit it in patch format? It's not possible to replace whole files as other changes may occur in the meantime. Here's one resource on how to create patches. http://james.apache.org/contribute.html I can also provide specific help for creating patches from Eclipse if you need it. Feel free to email me directly at mkienenb@gmail.com.
        Hide
        Swarn Dhaliwal added a comment -

        Here are the patches

        Show
        Swarn Dhaliwal added a comment - Here are the patches
        Hide
        Martin Marinschek added a comment -

        Thanks to Swarn Dhaliwal

        Show
        Martin Marinschek added a comment - Thanks to Swarn Dhaliwal

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Swarn Dhaliwal
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development