Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
Currently the AddResource.writeWithFullHeader method takes an ExtensionResponseWrapper object as a parameter.
This makes calling this method from places other than the ExtensionsFilter difficult. In particular, it makes it difficult
to call this method from a unit test.
As the only thing done with this parameter is to convert it to a string, the attached patch changes this API to take a
plain string parameter instead (and changes ExtensionsFilter to match).
This also makes the writeWithFullHeader method less coupled to the ExtensionsFilter class, and generally simpler
to understand.
I hope you find this patch useful.
Regards, Simon