[TOMAHAWK-355] Minor tweak to AddResource to make writing unit tests easier

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.2
• Assignee: Martin Marinschek
• Reporter: Simon Kitching
• Created: 09/Nov/05 07:01
• Updated: 07/May/06 01:42
• Resolved: 11/Nov/05 03:26

Description

Currently the AddResource.writeWithFullHeader method takes an ExtensionResponseWrapper object as a parameter.
This makes calling this method from places other than the ExtensionsFilter difficult. In particular, it makes it difficult
to call this method from a unit test.

As the only thing done with this parameter is to convert it to a string, the attached patch changes this API to take a
plain string parameter instead (and changes ExtensionsFilter to match).

This also makes the writeWithFullHeader method less coupled to the ExtensionsFilter class, and generally simpler
to understand.

I hope you find this patch useful.

Regards, Simon