[TOMAHAWK-337] incompatible change to jscookMenu

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.1.2
• Component/s: JS Cook Menu
• Assignee: Martin Marinschek
• Reporter: Simon Kitching
• Created: 13/Oct/05 10:43
• Updated: 04/Mar/07 06:57
• Resolved: 21/Oct/05 19:39

Description

The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an exception, with message:
"You provided a wrong themeName.".

I see that new features have been added to support custom themes. This is fine, but please restore the original behaviour of accepting an unknown themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1) should not have changes that break valid existing user code.

I currently implement a custom theme by passing my own theme name to the jscookMenu class and then ensuring that references to the appropriate .js and .css files are inserted into the page too. The old jscookMenu code simply accepted the unknown theme name, included that name in its generated inline javascript, and skipped output of any references to the .js/.css for a built-in theme.

The problem change is to class
org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer

Possibly a warning (logged or even output as a js comment) could be generated by the jscookMenu code to recommend to people that they modify their pages to use the new custom-theming attributes, but throwing an exception isn't nice.

This has been discussed on the user email list:
http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2