MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1609

tomahawk12 <t:htmlTag tag="br"/> generates <br></br> which many browsers parse as two break tags when parsing as HTML.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.8, 1.1.11
    • Fix Version/s: 1.1.12
    • Component/s: Html Tag
    • Labels:
      None
    • Environment:
      WebSphere 7.0.x using Firefox 9, IE 8 and 9, and Chrome

      Description

      In the tomahawk12 library htmlTag forces tags specified by the "tag"attribute to have separate start and end tags. However HTML specifically disallows certain tags, like 'br' having end tags. Many browsers parse the end 'br' tag as a second tag, rather than an end to the first tag.

      Note that the tomahawk (JSF 1.1 version) library does not do this. It has a different implementation of the HtmlTagRenderer.encodeEnd method.

        Activity

        Bob Mitchell created issue -
        Hide
        Leonardo Uribe added a comment -

        I checked it and there is a bad line that force ends all tags, but that is responsibility of the ResponseWriter provided by the Renderkit. I believe the code was added by some issue related to jsp long time ago. The right thing to do is remove that line and let ResponseWriter to close it properly or not. I can't found the svn revision this one was introduced, maybe when tomahawk core12 module was open. Anyway, I commented the line and added a comment.

        Show
        Leonardo Uribe added a comment - I checked it and there is a bad line that force ends all tags, but that is responsibility of the ResponseWriter provided by the Renderkit. I believe the code was added by some issue related to jsp long time ago. The right thing to do is remove that line and let ResponseWriter to close it properly or not. I can't found the svn revision this one was introduced, maybe when tomahawk core12 module was open. Anyway, I commented the line and added a comment.
        Leonardo Uribe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Leonardo Uribe [ lu4242 ]
        Fix Version/s 1.1.12-SNAPSHOT [ 12316481 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.12 [ 12320840 ]
        Fix Version/s 1.1.12-SNAPSHOT [ 12316481 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Bob Mitchell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development