[TOMAHAWK-1600] Do not enforce check ExtensionsFilter setup in tomahawk for JSF 2.0, because it is only required by 2 components

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.11
• Component/s: File Upload
• Assignee: Leonardo Uribe
• Reporter: Leonardo Uribe
• Created: 13/Jul/11 16:45
• Updated: 19/Jul/11 03:38
• Resolved: 14/Jul/11 00:04

Description

Checking some forums I notice ExtensionsFilter setup cause a lot of unnecessary pain.

In JSF 1.1 and 1.2, configure it is necessary but this is not true anymore with JSF 2.0, because almost all components are using JSF 2.0 standard ResourceHandler. The only components that really requires ExtensionsFilter / TomahawkFacesContextWrapper are t:inputFileUpload and t:stylesheet.

We should set org.apache.myfaces.CHECK_EXTENSIONS_FILTER by default to false, to allow webapp including tomahawk start without problem and without cause all that know issues related to multiple filters ordering. If t:inputFileUpload is used, the documentation must say in a detailed way how to setup and the problems that could happen with other libraries. Finally, a warning should be output if t:inputFileUpload is used and no ExtensionsFilter / TomahawkFacesContextWrapper is active.