MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1557

InputDate calendar popup does not render correctly on IE7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.11
    • Component/s: Calendar
    • Labels:
      None
    • Environment:
      Using Tomahawk 1.2 Jar file tomahawk12-1.1.9.jar

      Browser is IE7 on Windows XP

      Description

      Popup calendar does not render correctly on IE7 but renders OK of FF. In IE7 the popup takes the full width of the browser screen.

      Following tag used to generate the popup

      <t:inputDate id="#

      {id}" value="#{value}" renderAsPopup="#{true}" popupButtonImageUrl="images/icon_date.gif"
      popupDateFormat="dd/MM/yyyy" renderPopupButtonAsImage="true"
      popupCalendar="#{true}" converterMessage="#{id}

      is in wrong format"/>

      Issue appears to be a "feature" of IE7 where the setAttribute method in javascript does not work correctly. In the javascript used to generate the popup the width is set in the javascript org_apache_myfaces_PopupCalendar.prototype.init as follows

      mainTable.setAttribute("cssText", "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;");

      This does not appear to set the width correctly. The recommended workaround (which works for both IE7 and FF) is to set the cssText directly as follows:

      mainTable.style.cssText = "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;";

      I have tested this on both IE7 and FF and it seems to work OK.

      There are a number of other places in the javascript where the setAttribute is used to set the width and other style attributes - I assume these have the same problem - I have changed these and the popup appears to work OK

        Issue Links

          Activity

          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Leonardo Uribe made changes -
          Fix Version/s 1.1.11 [ 12316480 ]
          Fix Version/s 1.1.11-SNAPSHOT [ 12315372 ]
          Leonardo Uribe made changes -
          Link This issue relates to TOMAHAWK-1518 [ TOMAHAWK-1518 ]
          Leonardo Uribe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Leonardo Uribe [ lu4242 ]
          Fix Version/s 1.1.11-SNAPSHOT [ 12315372 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Component/s Calendar [ 12310749 ]
          Frank Davis made changes -
          Field Original Value New Value
          Description Popup calendar does not render correctly on IE87 but renders OK of FF. In IE7 the popup takes the full width of the browser screen.

          Following tag used to generate the popup

          <t:inputDate id="#{id}" value="#{value}" renderAsPopup="#{true}" popupButtonImageUrl="images/icon_date.gif"
          popupDateFormat="dd/MM/yyyy" renderPopupButtonAsImage="true"
          popupCalendar="#{true}" converterMessage="#{id} is in wrong format"/>


          Issue appears to be a "feature" of IE7 where the setAttribute method in javascript does not work correctly. In the javascript used to generate the popup the width is set in the javascript org_apache_myfaces_PopupCalendar.prototype.init as follows

          mainTable.setAttribute("cssText", "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;");

          This does not appear to set the width correctly. The recommended workaround (which works for both IE7 and FF) is to set the cssText directly as follows:

          mainTable.style.cssText = "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;";

          I have tested this on both IE7 and FF and it seems to work OK.

          There are a number of other places in the javascript where the setAttribute is used to set the width and other style attributes - I assume these have the same problem - I have changed these and the popup appears to work OK
          Popup calendar does not render correctly on IE7 but renders OK of FF. In IE7 the popup takes the full width of the browser screen.

          Following tag used to generate the popup

          <t:inputDate id="#{id}" value="#{value}" renderAsPopup="#{true}" popupButtonImageUrl="images/icon_date.gif"
          popupDateFormat="dd/MM/yyyy" renderPopupButtonAsImage="true"
          popupCalendar="#{true}" converterMessage="#{id} is in wrong format"/>


          Issue appears to be a "feature" of IE7 where the setAttribute method in javascript does not work correctly. In the javascript used to generate the popup the width is set in the javascript org_apache_myfaces_PopupCalendar.prototype.init as follows

          mainTable.setAttribute("cssText", "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;");

          This does not appear to set the width correctly. The recommended workaround (which works for both IE7 and FF) is to set the cssText directly as follows:

          mainTable.style.cssText = "width:" + ((this.initData.showWeekNumber == 1)?250:220) + "px;";

          I have tested this on both IE7 and FF and it seems to work OK.

          There are a number of other places in the javascript where the setAttribute is used to set the width and other style attributes - I assume these have the same problem - I have changed these and the popup appears to work OK
          Frank Davis created issue -

            People

            • Assignee:
              Leonardo Uribe
              Reporter:
              Frank Davis
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development