MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1496

HtmlTreeRenderer 'background-image' incorrect html style attribute

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.7, 1.1.8, 1.1.9
    • Fix Version/s: 1.1.10
    • Component/s: Tree2
    • Labels:
      None
    • Environment:
      Linux, firefox, ie

      Description

      Currently the "td" with the "line-trunk" images have the style to "background-image:/path/to/theImage.gif" and should be:
      "background-image:url('/path/to/theImage')" (see line 506). This bug produces that some trees with big images in the nodes looks bad.

        Activity

        Daniel del Río created issue -
        Daniel del Río made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Daniel del Río made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Ronald Müller added a comment -

        I just want to confirm this bug and add a patch. This bug is related to two lines in class HtmlTreeRenderer.

        BTW i took one day to get the tomahawk-sources compiled in my eclipse-ide and finally managed it by removing this single class from the tomahawk-binary and putting the HtmlTreeRenderer.java-sources to my workspace.

        in detail:

        i checked out the 'current'-folder (http://svn.apache.org/repos/asf/myfaces/current/)

        1) no way to compile tomahawk with maven: maven2 produced constantly build errors (only at the tomahawk-package, myfaces-core went fine)
        2) tried to compile only sources from package "org.apache.myfaces.custom.tree2" - there are some sources missing: (HtmlTree.java, TreeTag.java) last seen in version 1.1.6 !? (/myfaces/tomahawk/tags/1_1_6/core/src/main/java/org/apache/myfaces/custom/tree2), searched the whole myfaces-repo - but nothing (automatically generated ?)

        i personally think open source is a great idea and i want to support those projects whenever its possible to me. but in this case it was extremly complicated.

        Show
        Ronald Müller added a comment - I just want to confirm this bug and add a patch. This bug is related to two lines in class HtmlTreeRenderer. BTW i took one day to get the tomahawk-sources compiled in my eclipse-ide and finally managed it by removing this single class from the tomahawk-binary and putting the HtmlTreeRenderer.java-sources to my workspace. in detail: i checked out the 'current'-folder ( http://svn.apache.org/repos/asf/myfaces/current/ ) 1) no way to compile tomahawk with maven: maven2 produced constantly build errors (only at the tomahawk-package, myfaces-core went fine) 2) tried to compile only sources from package "org.apache.myfaces.custom.tree2" - there are some sources missing: (HtmlTree.java, TreeTag.java) last seen in version 1.1.6 !? (/myfaces/tomahawk/tags/1_1_6/core/src/main/java/org/apache/myfaces/custom/tree2), searched the whole myfaces-repo - but nothing (automatically generated ?) i personally think open source is a great idea and i want to support those projects whenever its possible to me. but in this case it was extremly complicated.
        Ronald Müller made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ronald Müller added a comment -

        Patch for correcting style-attribute (background-image) in HtmlTreeRenderer.java (tree2-component)

        Show
        Ronald Müller added a comment - Patch for correcting style-attribute (background-image) in HtmlTreeRenderer.java (tree2-component)
        Ronald Müller made changes -
        Attachment HtmlTreeRenderer.java.patch [ 12438498 ]
        Hide
        Leonardo Uribe added a comment -

        Thanks to Ronald Müller for provide this patch.

        Some files in myfaces core and tomahawk are automatically generated. Some time ago some issues related to build process were solved, so now it works fine.

        Show
        Leonardo Uribe added a comment - Thanks to Ronald Müller for provide this patch. Some files in myfaces core and tomahawk are automatically generated. Some time ago some issues related to build process were solved, so now it works fine.
        Leonardo Uribe made changes -
        Assignee Leonardo Uribe [ lu4242 ]
        Fix Version/s 1.1.10-SNAPSHOT [ 12314036 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.10 [ 12315371 ]
        Fix Version/s 1.1.10-SNAPSHOT [ 12314036 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Daniel del Río
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development