MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1395

selectManyCheckbox does not render space between checkbox and label on Firefox

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.9-SNAPSHOT
    • Fix Version/s: 1.1.9
    • Component/s: None
    • Labels:
      None
    • Environment:
      I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5

      Description

      The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.

        Activity

        Hide
        Joe Knudsen added a comment -

        On Firefox on space exists between the checkbox and the label.

        Show
        Joe Knudsen added a comment - On Firefox on space exists between the checkbox and the label.
        Hide
        Joe Knudsen added a comment -

        Should have said above. Using Firefox no space exists between the checkbox and the label. Looks fine on IE 7. Also tested h:selectManyCheckbox and that looks good on both.

        Show
        Joe Knudsen added a comment - Should have said above. Using Firefox no space exists between the checkbox and the label. Looks fine on IE 7. Also tested h:selectManyCheckbox and that looks good on both.
        Hide
        Joe Knudsen added a comment -

        Here is the HTML. It looks like just a space in needed. I may try to make the fix myself.

        <table class="DynamicContent" id="frmSearchDiscrepancies:chkAssessmentDiscrepancies"><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="3" />2008 Assessment data with errors.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="4" />2008 Assessment data inconsistent with 2008 MARSS enrollment data.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="5" />2008 Assessments not matched with 2008 MARSS enrollments.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="6" />2008 Assessments only matched with 2008 MARSS enrollments outside my district.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="7" />2008 Assessments without two years prior valid scores.</label></td></tr></table>

        Show
        Joe Knudsen added a comment - Here is the HTML. It looks like just a space in needed. I may try to make the fix myself. <table class="DynamicContent" id="frmSearchDiscrepancies:chkAssessmentDiscrepancies"><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="3" />2008 Assessment data with errors.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="4" />2008 Assessment data inconsistent with 2008 MARSS enrollment data.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="5" />2008 Assessments not matched with 2008 MARSS enrollments.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="6" />2008 Assessments only matched with 2008 MARSS enrollments outside my district.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="7" />2008 Assessments without two years prior valid scores.</label></td></tr></table>
        Hide
        Leonardo Uribe added a comment -

        It seems a simple css style can do it, but I don't believe we can do something. It seems you are using tomahawk-1.1.x. Does this happens in tomahawk12-1.1.x too?

        Show
        Leonardo Uribe added a comment - It seems a simple css style can do it, but I don't believe we can do something. It seems you are using tomahawk-1.1.x. Does this happens in tomahawk12-1.1.x too?
        Hide
        Joe Knudsen added a comment -

        Come on. The tomahawk widget should produce the same look as the JSF widget. I switched to using h:selectManyCheckbox where I do not have two columns and they look great. I tried using CSS after a day of effort I cannot get that to work. I am far from a CSS expert. It seems like a simple fix. I have added it to my code and I am using the tomahawk12-1-1.x but I cannot get the tests to pass so the build fails.

        Show
        Joe Knudsen added a comment - Come on. The tomahawk widget should produce the same look as the JSF widget. I switched to using h:selectManyCheckbox where I do not have two columns and they look great. I tried using CSS after a day of effort I cannot get that to work. I am far from a CSS expert. It seems like a simple fix. I have added it to my code and I am using the tomahawk12-1-1.x but I cannot get the tests to pass so the build fails.
        Hide
        Leonardo Uribe added a comment -

        After another checking, there was a missing

        writer.write(HTML.NBSP_ENTITY);

        before the label on the class org.apache.myfaces.renderkit.html.ext.HtmlCheckboxRenderer (file on tomahawk core12). The renderer on tomahawk core is fine. Thanks for the attention in the details.

        Show
        Leonardo Uribe added a comment - After another checking, there was a missing writer.write(HTML.NBSP_ENTITY); before the label on the class org.apache.myfaces.renderkit.html.ext.HtmlCheckboxRenderer (file on tomahawk core12). The renderer on tomahawk core is fine. Thanks for the attention in the details.

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Joe Knudsen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development